[PATCH] ARM: tegra: add cpu_disable for hotplug

Peter De Schrijver pdeschrijver at nvidia.com
Wed May 22 05:03:04 EDT 2013


On Tue, May 21, 2013 at 06:15:48PM +0200, Stephen Warren wrote:
> On 05/21/2013 04:13 AM, Joseph Lo wrote:
> > The Tegra114 could hotplug the CPU0, but the common cpu_disable didn't
> > support that. Adding a Tegra specific cpu_disable function for it.
> > 
> > Signed-off-by: Joseph Lo <josephl at nvidia.com>
> 
> > diff --git a/arch/arm/mach-tegra/hotplug.c b/arch/arm/mach-tegra/hotplug.c
> 
> > +int tegra_cpu_disable(unsigned int cpu)
> > +{
> > +	switch (tegra_chip_id) {
> > +	case TEGRA114:
> > +		return 0;
> > +	default:
> > +		return cpu == 0 ? -EPERM : 0;
> > +	}
> > +}
> 
> Do we expect all/most future chips to support hotplug of CPU0? Or at
> least, fewer chips to have the restriction than not? If so, it might be

Yes. I think we can safely assume future chips will support hotplugging CPU0.

> more forward-looking to write that as:
> 
> if (tegra_chip_id == TEGRA30)
>     return cpu == 0 ? -EPERM : 0;
> 

Also Tegra20 doesn't support hotplugging CPU0?

Cheers,

Peter.



More information about the linux-arm-kernel mailing list