[PATCH v4 21/32] arm64: KVM: Build system integration

[Catalin Marinas]

On Tue, May 21, 2013 at 05:09:47PM +0100, Paolo Bonzini wrote:
> 
> 
> ----- Messaggio originale -----
> > Da: "Catalin Marinas" <catalin.marinas at arm.com>
> > A: "Marc Zyngier" <Marc.Zyngier at arm.com>
> > Cc: linux-arm-kernel at lists.infradead.org, kvmarm at lists.cs.columbia.edu, kvm at vger.kernel.org, "Will Deacon"
> > <Will.Deacon at arm.com>, pbonzini at redhat.com, gleb at redhat.com, "Christopher Covington" <cov at codeaurora.org>
> > Inviato: Martedì, 21 maggio 2013 17:42:27
> > Oggetto: Re: [PATCH v4 21/32] arm64: KVM: Build system integration
> > 
> > On Tue, May 14, 2013 at 03:13:49PM +0100, Marc Zyngier wrote:
> > > --- /dev/null
> > > +++ b/arch/arm64/kvm/Kconfig
> > ...
> > > +config KVM_ARM_VGIC
> > > +        bool
> > > +	depends on KVM_ARM_HOST && OF
> > > +	select HAVE_KVM_IRQCHIP
> > > +	---help---
> > > +	  Adds support for a hardware assisted, in-kernel GIC emulation.
> > > +
> > > +config KVM_ARM_TIMER
> > > +        bool
> > > +	depends on KVM_ARM_VGIC
> > > +	select HAVE_KVM_IRQCHIP
> > > +	---help---
> > > +	  Adds support for the Architected Timers in virtual machines
> > > +
> > > +source drivers/virtio/Kconfig
> > 
> > Shouldn't the above configs go to drivers/virtio/Kconfig as well (or
> > drivers/virtio/arm/Kconfig)?
> 
> virtio doesn't mean "virtual versions of devices that also exist in
> hardware"; those are indeed in arch/ARCH/kvm.  virtio is a specific bus
> for paravirtualized devices.  It is not KVM-specific and the code runs
> in the guest (whereas arch/arm64/kvm/Kconfig is host code).

You are right. What I meant was kvm/virt/arm/Kconfig (the place where
the vgic and timer driver goes).

-- 
Catalin