[PATCH v2 6/6] pinctrl: exynos: Handle suspend/resume of GPIO EINT registers

Doug Anderson dianders at chromium.org
Wed May 22 00:46:35 EDT 2013


Tomasz,

On Tue, May 21, 2013 at 10:05 AM, Tomasz Figa <t.figa at samsung.com> wrote:
>         return 0;
> +
> +err_domains:
> +       bank = d->ctrl->pin_banks;
> +       for (undo = 0; undo < i; ++undo) {

++bank is missing, I think.  This will free the same bank many times.

optional: could also avoid extra 'undo' variable and remove in reverse
order by changing i to signed and counting down to 0.

-Doug



More information about the linux-arm-kernel mailing list