[PATCH] arm64: kernel: need extern variable 'screen_info' for related driver using.

Geert Uytterhoeven geert at linux-m68k.org
Tue May 21 02:57:36 EDT 2013


On Tue, May 21, 2013 at 5:15 AM, Chen Gang <gang.chen at asianux.com> wrote:
>> I think it would be better if we added a something like
>> CONFIG_HAVE_VGA_CONSOLE, which VGA_CONSOLE can then depend on. Architectures
>> like x86 can then select the former, and we can remove the long list of
>> architectures from the current option.
>
> I guess your meaning is:
>
>   under arm64, actually, need not support 'VGA_CONSOLE', and 'screen_info' is useless.
>   So better to define 'CONFIG_HAVE_VGA_CONSOLE' which 'VGA_CONSOLE' can depend on it, and in arm64, we do not define CONFIG_HAVE_VGA_CONSOLE.
>
> Is it correct ?

No, you missed "and we can remove the long list of architectures from the
current option".

> If so, I recommend to add depend item for VGA_CONSOLE directly:

I strongly support CONFIG_HAVE_VGA_CONSOLE.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



More information about the linux-arm-kernel mailing list