[PATCH v2] ARM: sunxi: New watchdog driver for Allwinner A10/A13

[Carlo Caione]

On May 19, 2013, at 5:32 PM, Maxime Ripard <maxime.ripard at free-electrons.com> wrote:

> Hi Carlo,

Hi Maxime,

>> +
>> +#define WDT_CTRL                0x00
>> +#define WDT_CTRL_RESTART        (1 << 0)
>> +#define WDT_CTRL_RESERVED       (0x0a57 << 1)
> 
> You didn't replied to me on that part in the previous mail. It doesn't
> seem to be needed, so why keeping it?

Actually I wrote you about this on irc (probably you were afk)
Anyway I tested the driver without using the 0x0a57 and without these bits the watchdog is never successfully kicked.
I'm going to submit a v3 soon, addressing also the suggestions given by Henrik on linux-sunxi ml.

Regards,

--
Carlo Caione