[PATCH v2] ARM: KVM: prevent NULL pointer dereferences with KVM VCPU ioctl

Andre Przywara andre.przywara at linaro.org
Tue May 14 03:07:43 EDT 2013


On 05/14/2013 12:42 AM, Christoffer Dall wrote:
> On Mon, May 13, 2013 at 3:23 PM, Andre Przywara
> <andre.przywara at linaro.org> wrote:
>> ooks like a natural candidate, but unfortunately struct kvm_vcpu is opaque
>> here, so dereferencing it does not work without further changes which I do
>> not deem to be justified. I used kvm_coproc.h instead, which is loosely
>> related (KVM_[SG]ET_ONE_REG) and just simply works. If you don't think
>> that's appropriate, just drop me a note. Patch follows in a separate mail.
>
> eh, not crazy about the idea. x86 has
> arch/x86/include/asm/kvm_guest.h, which may be the most appropriate,
> or this could be generalized to other architectures as well and
> included in include/linux/kvm_host.h.
>
> we can just stick it in arch/arm/kvm/arm.c for now and move later if
> need be, no need to create a fuzz.

Ok, would you mind to commit v2 and add the "inline" on the way?

Thanks,
Andre.




More information about the linux-arm-kernel mailing list