[PATCH 09/63] dmaengine: ste_dma40: Rectify incorrect configuration validation checking

Linus Walleij linus.walleij at linaro.org
Fri May 3 15:58:16 EDT 2013


On Fri, May 3, 2013 at 4:31 PM, Lee Jones <lee.jones at linaro.org> wrote:

> If we compare an event's group (dev_type / 16) with STEDMA40_DEV_DST_MEMORY
> (-1), the only way we'd obtain a positive result is if we passed -16 as a
> device type, which is unfeasible. Instead, it would be much more sane to
> compare STEDMA40_DEV_DST_MEMORY against the raw dev_type in order to expect
> the expected result.
>
> Signed-off-by: Lee Jones <lee.jones at linaro.org>

I'd like Vinod's ACK on this before I send it to ARM SoC but tentatively
applied (and just what I wanted!)

Vinod can I have your ACK on this?

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list