[PATCH 2/4] mfd: ab8500-gpadc: Suppress 'ignoring regulator_enable() return value' warning

Linus Walleij linus.walleij at linaro.org
Fri May 3 04:28:28 EDT 2013


On Thu, May 2, 2013 at 5:48 PM, Lee Jones <lee.jones at linaro.org> wrote:
> drivers/mfd/ab8500-gpadc.c: In function ‘ab8500_gpadc_resume’:
> drivers/mfd/ab8500-gpadc.c:911:18: warning: ignoring return value of
>         ‘regulator_enable’, declared with attribute warn_unused_result
>         [-Wunused-result]
>
> Cc: Samuel Ortiz <sameo at linux.intel.com>
> Signed-off-by: Lee Jones <lee.jones at linaro.org>
> ---
>  drivers/mfd/ab8500-gpadc.c |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/ab8500-gpadc.c b/drivers/mfd/ab8500-gpadc.c
> index 5e65b28..7278e53 100644
> --- a/drivers/mfd/ab8500-gpadc.c
> +++ b/drivers/mfd/ab8500-gpadc.c
> @@ -907,8 +907,11 @@ static int ab8500_gpadc_suspend(struct device *dev)
>  static int ab8500_gpadc_resume(struct device *dev)
>  {
>         struct ab8500_gpadc *gpadc = dev_get_drvdata(dev);
> +       int ret;
>
> -       regulator_enable(gpadc->regu);
> +       ret = regulator_enable(gpadc->regu);
> +       if (ret < 0)
> +               return ret;
>
>         pm_runtime_mark_last_busy(gpadc->dev);
>         pm_runtime_put_autosuspend(gpadc->dev);
> --
> 1.7.10.4

Acked-by: Linus Walleij <linus.walleij at linaro.org>

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list