[PATCH, RFC 02/22] cpufreq: ARM_DT_BL_CPUFREQ needs ARM_CPU_TOPOLOGY
viresh.kumar at linaro.org
Fri May 3 00:51:45 EDT 2013
On 2 May 2013 20:46, Arnd Bergmann <arnd at arndb.de> wrote:
> The big.LITTLE cpufreq driver uses the CPU topology API, which
> needs to be reflected in Kconfig to prevent broken configurations.
> warning: (ARM_DT_BL_CPUFREQ) selects ARM_BIG_LITTLE_CPUFREQ which
> has unmet direct dependencies (ARCH_HAS_CPUFREQ && CPU_FREQ && ARM && ARM_CPU_TOPOLOGY)
> Cc: Rafael J. Wysocki <rjw at sisk.pl>
> Cc: Viresh Kumar <viresh.kumar at linaro.org>
> Cc: cpufreq at vger.kernel.org
> Cc: linux-pm at vger.kernel.org
> Signed-off-by: Arnd Bergmann <arnd at arndb.de>
> drivers/cpufreq/Kconfig.arm | 1 +
> 1 file changed, 1 insertion(+)
> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> index f3af18b..3fd6bdf 100644
> --- a/drivers/cpufreq/Kconfig.arm
> +++ b/drivers/cpufreq/Kconfig.arm
> @@ -10,6 +10,7 @@ config ARM_DT_BL_CPUFREQ
> tristate "Generic ARM big LITTLE CPUfreq driver probed via DT"
> select ARM_BIG_LITTLE_CPUFREQ
> depends on OF && HAVE_CLK
> + depends on ARM_CPU_TOPOLOGY
> This enables the Generic CPUfreq driver for ARM big.LITTLE platform.
> This gets frequency tables from DT.
This Kconfig thing has always been confusing to me. This is how the code looks
depends on ARM_CPU_TOPOLOGY
tristate "Generic ARM big LITTLE CPUfreq driver probed via DT"
depends on OF && HAVE_CLK
This enables the Generic CPUfreq driver for ARM big.LITTLE platform.
This gets frequency tables from DT.
Because all ARM big LITTLE cpufreq stuff have dependency on
ARM_CPU_TOPOLOGY, i have added dependency at a common place. So that
we don't end up adding this in every glue layer driver. How should this be done?
More information about the linux-arm-kernel