[PATCH] arm: mvebu: Fix the memory size on the Mirabox

[Jason Cooper]

On Fri, Mar 29, 2013 at 04:37:17PM -0300, Ezequiel Garcia wrote:
> On Fri, Mar 29, 2013 at 11:09:23AM -0700, Ryan Press wrote:
> > Hi Jason,
> > 
> > On Fri, Mar 29, 2013 at 11:04 AM, Jason Cooper <jason at lakedaemon.net> wrote:
> > > On Fri, Mar 29, 2013 at 10:51:17AM -0700, Ryan Press wrote:
> > >> The memory size in the device tree is only 512 MB, but the
> > >> Mirabox actually has 1 GB.
> > >>
> > >> Tested the change with memtester and no problems found.
> > >>
> > >> Signed-off-by: Ryan Press <ryan at presslab.us>
> > >> ---
> > >>  arch/arm/boot/dts/armada-370-mirabox.dts | 2 +-
> > >>  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > Thanks for the patch.  It looks good, but please don't forget to Cc: the
> > > maintainers (Andrew Lunn, Gregory Clemente, and myself).  I almost
> > > missed this one. :)
> > >
> 
> As far as I can remember, Gregory has a Mirabox with only 512 MiB,
> which means some boards were shipped with 512 MiB and some with 1 GiB.
> Moreover, apparently nothing can distinguish one from the other.
> 
> @Gregory: can you confirm this?
> 
> If Gregory confirms this, then we shouldn't apply this patch.
> Don't forget in-kernel DTS are only meant for developers and
> for reference. The vendor (Globalscale in this case) has to ship
> a proper DTS for each board.

In this case, the bootloader should be amending the dtb to provide the
correct value for the particular board.  If your bootloader is
devicetree-capable, it'll happen auto-magically.  Otherwise, you'll need
to enable ARM_ATAG_DTB_COMPAT.

I'll drop this patch unless Gregory says it's ok.

hth,

Jason.