[PATCH 1/2] ARM: irq: Call irqchit_init if no init_irq function is specified
Russell King - ARM Linux
linux at arm.linux.org.uk
Thu Mar 28 15:02:08 EDT 2013
On Thu, Mar 28, 2013 at 01:40:09PM -0500, Rob Herring wrote:
> On 03/28/2013 09:51 AM, Russell King - ARM Linux wrote:
> > On Thu, Mar 28, 2013 at 09:48:18AM -0500, Rob Herring wrote:
> >> On 03/28/2013 04:41 AM, Maxime Ripard wrote:
> >>> + if (machine_desc->init_irq)
> >>> + machine_desc->init_irq();
> >>> + else
> >>> + irqchip_init();
> >>
> >> There needs to be an empty version defined for !OF.
> >
> > Better:
> >
> > #ifdef CONFIG_OF
> > if (!machine_desc->init_irq)
> > irqchip_init();
> > else
> > #endif
>
> Or the new style:
>
> if (IS_ENABLED(CONFIG_OF) && !machine_desc->init_irq)
> irqchip_init();
> else
>
> That needs the empty version, but handles your case.
It shouldn't need the empty version at all - because the compiler should
optimize the "true" case away entirely.
More information about the linux-arm-kernel
mailing list