[PATCH 5/5] ARM: dts: AM33XX: Add default pinctrl binding for UART0 device

[Hiremath, Vaibhav]

> -----Original Message-----
> From: Matt Porter [mailto:ohiomdp at gmail.com] On Behalf Of Porter, Matt
> Sent: Wednesday, March 27, 2013 7:03 PM
> To: Hiremath, Vaibhav
> Cc: linux-omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org;
> Cousson, Benoit; devicetree-discuss at lists.ozlabs.org
> Subject: Re: [PATCH 5/5] ARM: dts: AM33XX: Add default pinctrl binding
> for UART0 device
> 
> On Wed, Mar 27, 2013 at 12:59:16PM +0000, Vaibhav Hiremath wrote:
> > Add pin control binding for UART0 device nodes in all
> > board specific DT files.
> >
> > Signed-off-by: Vaibhav Hiremath <hvaibhav at ti.com>
> > Cc: Benoit Cousson <b-cousson at ti.com>
> 
> Except for trivial comments below I'll add my
> 
> Acked-by: Matt Porter <mporter at ti.com>
> 
> > ---
> >  arch/arm/boot/dts/am335x-bone.dts  |   10 ++++++++++
> >  arch/arm/boot/dts/am335x-evm.dts   |   10 ++++++++++
> >  arch/arm/boot/dts/am335x-evmsk.dts |   10 ++++++++++
> >  3 files changed, 30 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/am335x-bone.dts
> b/arch/arm/boot/dts/am335x-bone.dts
> > index 1d623e4..3c4c66f 100644
> > --- a/arch/arm/boot/dts/am335x-bone.dts
> > +++ b/arch/arm/boot/dts/am335x-bone.dts
> > @@ -43,10 +43,20 @@
> >  				0x18c 0x30	/* i2c0_scl.i2c0_scl PULLUP |
> INPUTENABLE | MODE0 */
> >  			>;
> >  		};
> > +
> > +		uart0_pins: pinmux_uart0_pins {
> > +			pinctrl-single,pins = <
> > +				0x170 0x30	/* uart0_rxd.uart0_rxd PULLUP |
> INPUTENABLE | MODE0 */
> > +				0x174 0x00	/* uart0_txd.uart0_txd PULLDOWN |
> MODE0 */
> > +			>;
> > +		};
> >  	};
> >
> >  	ocp {
> >  		uart1: serial at 44e09000 {
> > +			pinctrl-names = "default";
> > +			pinctrl-0 = <&uart0_pins>;
> > +
> 
> Please change this to be uart0 so it all matches.
> 
Yes, you are right, this also can be changed now.
I tested it with changed uart numbering and it is working.

I didn’t touch uart, as I recall earlier discussion of
Having 1-based uart numbering and also it is being documented
In DT for hwmod -

ti,hwmods : Must be "uart<n>", n being the instance number (1-based)


I will change it and submit the next version with your acked-by.

Thanks,
Vaibhav