[PATCH 4/9] ARM: OMAP4+: Remove the un-necessary cache flush from hotplug code

Kevin Hilman khilman at linaro.org
Wed Mar 27 14:43:24 EDT 2013


Santosh Shilimkar <santosh.shilimkar at ti.com> writes:

> This was added with intial port where OMAP PM support wasn't existing
> and only simple WFI based hooks were used.
>
> This should have been cleaned up while adding the PM support but some
> how fall through cracks.

Changelog describes a bit of history, but does not it's no longer
needed.

Kevin

> Signed-off-by: Santosh Shilimkar <santosh.shilimkar at ti.com>
> ---
>  arch/arm/mach-omap2/omap-hotplug.c |    6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap-hotplug.c b/arch/arm/mach-omap2/omap-hotplug.c
> index e712d17..458f72f 100644
> --- a/arch/arm/mach-omap2/omap-hotplug.c
> +++ b/arch/arm/mach-omap2/omap-hotplug.c
> @@ -19,11 +19,8 @@
>  #include <linux/smp.h>
>  #include <linux/io.h>
>  
> -#include <asm/cacheflush.h>
>  #include "omap-wakeupgen.h"
> -
>  #include "common.h"
> -
>  #include "powerdomain.h"
>  
>  /*
> @@ -35,9 +32,6 @@ void __ref omap4_cpu_die(unsigned int cpu)
>  	unsigned int boot_cpu = 0;
>  	void __iomem *base = omap_get_wakeupgen_base();
>  
> -	flush_cache_all();
> -	dsb();
> -
>  	/*
>  	 * we're ready for shutdown now, so do it
>  	 */



More information about the linux-arm-kernel mailing list