[PATCH] i2c: sirf: get the i2c pin group by pinctrl api

Barry Song 21cnbao at gmail.com
Wed Mar 27 06:36:46 EDT 2013


2013/3/27 Linus Walleij <linus.walleij at linaro.org>:
> On Mon, Mar 18, 2013 at 8:22 AM, Barry Song <Barry.Song at csr.com> wrote:
>
>> From: Barry Song <Baohua.Song at csr.com>
>>
>> hardcode set i2c pin group to i2c function before, here we
>> move to use standard pinctrl API to get pins of the group.
>>
>> Signed-off-by: Barry Song <Baohua.Song at csr.com>
>> Cc: Linus Walleij <linus.walleij at linaro.org>
>
> NAK.
>
> This is done by the device core as of commit
> ab78029ecc347debbd737f06688d788bd9d60c1d
> "drivers/pinctrl: grab default handles from device core".
>
> You only need to fetch pinctrl handles in drivers if you're
> using anything else than the default state.

well. missed this recent commit.
it should mean we hould drop all devm_pinctrl_get_select_default() if
the driver only takes the default pinctrl?

it looks like there are still a lot of drivers doing that. anyway, i
will drop them in SiRFsoc drivers. and involve you in the coming
patch.

>
> Yours,
> Linus Walleij
>

-barry



More information about the linux-arm-kernel mailing list