[PATCH 0/8] SIRF multiplatform support

Barry Song 21cnbao at gmail.com
Tue Mar 26 21:48:00 EDT 2013


2013/3/26 Arnd Bergmann <arnd at arndb.de>:
> On Tuesday 26 March 2013, Barry Song wrote:
>> everything is fine except that:
>> 1. Shawn Guo's uncompress debug patch is not in the tree, so the
>> uncompress debug is break. but that is not an issue
>
> Right.
>
>> 2. i want to change:
>> #define SIRFSOC_NUM_IRQS                128
>> to:
>> #define SIRFSOC_NUM_IRQS                64
>> the old 128 is suitable for marco, in fact prima2/atlas6 is 64. in
>> order that all SoCs can use the same irqs.h headfile, i pick the
>> biggest value. since now we have moved to linear irq, i want to fix it
>> back.
>>
>> then nr_irqs in DT_MACHINE_START(ATLAS6_DT/PRIMA2_DT should also take 64.
>
> Yes, sounds good.
>
>> 3. will we have similar codes between prima2 and marco for initilizing
>> timer tick?
>> CLOCKSOURCE_OF_DECLARE(sirfsoc_marco_timer, "sirf,marco-tick",
>> sirfsoc_of_timer_init );
>> CLOCKSOURCE_OF_DECLARE(sirfsoc_prima2_timer, "sirf,prima2-tick",
>> sirfsoc_prima2_timer_init);
>>
>> will we change "CLOCKSOURCE_OF_DECLARE(sirfsoc_marco_timer,
>> "sirf,marco-tick", sirfsoc_of_timer_init )" to things like
>> "CLOCKSOURCE_OF_DECLARE(sirfsoc_marco_timer, "sirf,marco-tick",
>> sirfsoc_marco_timer_init )" as prima2 does and drop
>>
>> anyway, this is a trivial issue.
>
> Yes, it seemed less invasive to do it without that change for marco.
>
> Since these changes are now just cosmetic, how about I pull the branch
> I have into the arm-soc tree and you do any further changes you'd like
> on top?

agree.

>
> It may also be a good point in time now to rename the directory to
> mach-sirf or mach-sirfsoc now as you suggested for an earlier release,
> since we have moved a lot of code out of it now. Any patches against
> the drivers that are getting moved will have to change anyway.

yes. i do like we rename mach-prima2 to mach-sirf. as prima2, atlas6,
marco are all CSR SiRF family SoCs.

>
>         Arnd

-barry



More information about the linux-arm-kernel mailing list