[PATCH 03/10] clocksource: sunxi: make use of CLKSRC_OF
Maxime Ripard
maxime.ripard at free-electrons.com
Mon Mar 25 12:23:54 EDT 2013
Hi Rob,
Le 25/03/2013 14:50, Rob Herring a écrit :
> On 03/25/2013 08:30 AM, Maxime Ripard wrote:
>> Using CLKSRC_OF allows to remove the SoC specific sunxi_timer.h header,
>> and instead of using a custom init function in the machine definition
>> use the standard clocksource_of_init function.
>>
>> Signed-off-by: Maxime Ripard <maxime.ripard at free-electrons.com>
>
> [...]
>
>> @@ -158,3 +157,5 @@ void __init sunxi_timer_init(void)
>> clockevents_config_and_register(&sunxi_clockevent, rate / TIMER_SCAL,
>> 0x1, 0xff);
>> }
>> +CLOCKSOURCE_OF_DECLARE(sunxi, "allwinner,sun4i-timer",
>> + sunxi_timer_init);
>
> You should base this on clocksource clean-up branch "clksrc/cleanup" in
> arm-soc. That will get rid of double matching and match table.
>
> Also, sunxi_timer_init can be static now.
Ah, thanks, I missed these patches.
I'll do that and send a v2.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the linux-arm-kernel
mailing list