[PATCH 08/10] ARM: sunxi: dt: Update interrupt controller compatible string
Rob Herring
robherring2 at gmail.com
Mon Mar 25 09:59:01 EDT 2013
On 03/25/2013 08:30 AM, Maxime Ripard wrote:
> Signed-off-by: Maxime Ripard <maxime.ripard at free-electrons.com>
> ---
> arch/arm/boot/dts/sun4i-a10.dtsi | 2 +-
> arch/arm/boot/dts/sun5i-a13.dtsi | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi
> index be71782..805d704 100644
> --- a/arch/arm/boot/dts/sun4i-a10.dtsi
> +++ b/arch/arm/boot/dts/sun4i-a10.dtsi
> @@ -121,7 +121,7 @@
> ranges;
>
> intc: interrupt-controller at 01c20400 {
> - compatible = "allwinner,sunxi-ic";
> + compatible = "allwinner,sun4i-ic";
Generally speaking, this is a bad thing to do. This breaks compatibility
between dtb and kernel versions. If that breakage is not yet a concern
for sunxi, then it is okay.
Also, I don't see any documentation updates for any of these changes.
Rob
> reg = <0x01c20400 0x400>;
> interrupt-controller;
> #interrupt-cells = <1>;
> diff --git a/arch/arm/boot/dts/sun5i-a13.dtsi b/arch/arm/boot/dts/sun5i-a13.dtsi
> index 7a81aaf..760222c 100644
> --- a/arch/arm/boot/dts/sun5i-a13.dtsi
> +++ b/arch/arm/boot/dts/sun5i-a13.dtsi
> @@ -122,7 +122,7 @@
> ranges;
>
> intc: interrupt-controller at 01c20400 {
> - compatible = "allwinner,sunxi-ic";
> + compatible = "allwinner,sun4i-ic";
> reg = <0x01c20400 0x400>;
> interrupt-controller;
> #interrupt-cells = <1>;
>
More information about the linux-arm-kernel
mailing list