[PATCHv2 1/4] arm: orion5x: fix orion5x.dtsi gpio parameters
Andrew Lunn
andrew at lunn.ch
Mon Mar 25 04:43:12 EDT 2013
On Sat, Mar 23, 2013 at 10:29:54PM +0000, Alexander Clouter wrote:
> orion5x.dtsi is missing the gpio alias as well as including a typo
> ('ngpio' instead of 'ngpios') that prevented the orion-gpio driver
> from loading. This patches resolves this.
>
> Signed-off-by: Alexander Clouter <alex at digriz.org.uk>
> ---
> arch/arm/boot/dts/orion5x.dtsi | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/orion5x.dtsi b/arch/arm/boot/dts/orion5x.dtsi
> index 8aad00f..9bde027 100644
> --- a/arch/arm/boot/dts/orion5x.dtsi
> +++ b/arch/arm/boot/dts/orion5x.dtsi
> @@ -13,6 +13,9 @@
> compatible = "marvell,orion5x";
> interrupt-parent = <&intc>;
>
> + aliases {
> + gpio0 = &gpio0;
> + };
> intc: interrupt-controller {
> compatible = "marvell,orion-intc", "marvell,intc";
> interrupt-controller;
> @@ -32,7 +35,7 @@
> #gpio-cells = <2>;
> gpio-controller;
> reg = <0x10100 0x40>;
> - ngpio = <32>;
> + ngpios = <32>;
> interrupts = <6>, <7>, <8>, <9>;
> };
Hi Alex
If you look at Dove, Kirkwood, etc, you see:
gpio0: gpio at d0400 {
compatible = "marvell,orion-gpio";
#gpio-cells = <2>;
gpio-controller;
reg = <0xd0400 0x20>;
ngpios = <32>;
interrupt-controller;
#interrupt-cells = <2>;
interrupts = <12>, <13>, <14>, <60>;
};
I think you also need to add
interrupt-controller;
#interrupt-cells = <2>;
Andrew
More information about the linux-arm-kernel
mailing list