[PATCH V2 1/3] clk: Restructure code for __clk_reparent

Ulf Hansson ulf.hansson at linaro.org
Fri Mar 22 07:08:09 EDT 2013


On 21 March 2013 21:53, Mike Turquette <mturquette at linaro.org> wrote:
> Quoting Ulf Hansson (2013-03-21 06:48:11)
>> +void __clk_reparent(struct clk *clk, struct clk *new_parent)
>> +{
>> +       clk_reparent(clk, new_parent);
>> +       clk_debug_reparent(clk, new_parent);
>>         __clk_recalc_rates(clk, POST_RATE_CHANGE);
>>  }
>>
>> @@ -1364,7 +1378,9 @@ int clk_set_parent(struct clk *clk, struct clk *parent)
>>         }
>>
>>         /* propagate rate recalculation downstream */
>> -       __clk_reparent(clk, parent);
>> +       clk_reparent(clk, parent);
>> +       clk_debug_reparent(clk, parent);
>> +       __clk_recalc_rates(clk, POST_RATE_CHANGE);
>>
>
> This is an interesting change.  Why not call __clk_reparent here instead
> of open coding an identical sequence?

By lazyness when rebasing patches I decided to keep it. :-) Well, my
idea here was also to make it visible how these three calls will be
split out to be called from three different places.

Do you want me to fixup?

Br
Uffe

>
> Regards,
> Mike



More information about the linux-arm-kernel mailing list