[PATCH v2 0/3] clock driver for sunxi

[Mike Turquette]

Quoting Emilio López (2013-02-25 06:44:25)
> Hello everyone,
> 
> This patchset adds basic clock support for sunxi devices. Currently, it
> implements support for the two oscillators, the main PLL, the CPU mux,
> its three divisor clocks and APB1. With this in place, it is possible to
> write a cpufreq driver and have it work, and with a little more code,
> represent the UART clocks correctly (I will be sending a separate
> patchset for this).
> 
> I have tested this driver successfully on a Cubieboard (A10, sun4i)
> using the cpufreq driver from the linux-sunxi tree after minor
> modifications (the clock names are not the same).
> 
> Any feedback will be highly appreciated
> 

Emilio,

This is a nice series.  I appreciate the amount of comments in the code,
the kerneldoc and also the added sunxi clock documentation.

Concerning the discussion from the v1 series, I prefer for the struct
clk instances in the tree to match 1-to-1 with hardware clocks.  As the
number of clocks in a system scales into the hundreds there are
certainly advantages to having fewer clocks in the hierarchy, not the
least of which is more easily associating these objects with hardware
clocks during a deep debug session.

That can be changed at a later time if you wish.  Do you want me to take
the series into clk-next or do you just want my ack?

Thanks,
Mike

> Thanks,
> 
> Emilio
> 
> Overview of changes from v1:
>   * Implement APB1
>   * Add missing glue for driver that got dropped on torvalds/master
>   * Drop "fixed gate" code and implement it with two clocks as suggested
>     by Gregory
> 
> Emilio López (3):
>   clk: arm: sunxi: Add a new clock driver for sunxi SOCs
>   arm: sunxi: Add clock definitions for the new clock driver
>   arm: sunxi: Add useful information about sunxi clocks
> 
>  Documentation/arm/sunxi/clocks.txt                |  56 ++++
>  Documentation/devicetree/bindings/clock/sunxi.txt |  44 +++
>  arch/arm/boot/dts/sunxi.dtsi                      |  83 ++++-
>  drivers/clk/Makefile                              |   1 +
>  drivers/clk/sunxi/Makefile                        |   5 +
>  drivers/clk/sunxi/clk-factors.c                   | 180 +++++++++++
>  drivers/clk/sunxi/clk-factors.h                   |  27 ++
>  drivers/clk/sunxi/clk-sunxi.c                     | 362 ++++++++++++++++++++++
>  drivers/clocksource/sunxi_timer.c                 |   4 +-
>  include/linux/clk/sunxi.h                         |  22 ++
>  10 files changed, 779 insertions(+), 5 deletions(-)
>  create mode 100644 Documentation/arm/sunxi/clocks.txt
>  create mode 100644 Documentation/devicetree/bindings/clock/sunxi.txt
>  create mode 100644 drivers/clk/sunxi/Makefile
>  create mode 100644 drivers/clk/sunxi/clk-factors.c
>  create mode 100644 drivers/clk/sunxi/clk-factors.h
>  create mode 100644 drivers/clk/sunxi/clk-sunxi.c
>  create mode 100644 include/linux/clk/sunxi.h
> 
> -- 
> 1.8.2.rc0