[PATCH 02/11] ARM: remove extra timer-sp control register clearing

Russell King - ARM Linux linux at arm.linux.org.uk
Thu Mar 21 15:23:22 EDT 2013


On Wed, Mar 20, 2013 at 05:54:02PM -0500, Rob Herring wrote:
> From: Rob Herring <rob.herring at calxeda.com>
> 
> The timer-sp initialization code clears the control register before
> initializing the timers, so every platform doing this is redundant.
> 
> For unused timers, we should not care what state they are in.

NAK.  We do care what state they're in.  What if they have their interrupt
enable bit set, and IRQ is shared with the clock event timer?

No, this patch is just wrong.



More information about the linux-arm-kernel mailing list