[PATCH 4/6] mfd: db8500-prcmu: get base address from resource

Arnd Bergmann arnd at arndb.de
Thu Mar 21 08:15:50 EDT 2013


On Thursday 21 March 2013 12:49:11 Linus Walleij wrote:
> -#define PRCM_PLLARM_LOCKP       (_PRCMU_BASE + 0x0a8)
> +#define PRCM_PLLARM_LOCKP       (prcmu_base + 0x0a8)
>  #define PRCM_PLLARM_LOCKP_PRCM_PLLARM_LOCKP3   0x2

While this is certainly the least invasive way to get rid of _PRCMU_BASE,
it sucks to refer to local variables in macros. How hard would it
be to find all users of these macros and put the prcmu_base addition
there?

The rest of this patch looks fine to me.

	Arnd



More information about the linux-arm-kernel mailing list