[PATCH 06/16] thermal: mvebu: Convert to devm_ioremap_resource()
Andrew Lunn
andrew at lunn.ch
Thu Mar 21 02:10:24 EDT 2013
On Wed, Mar 20, 2013 at 07:36:27PM -0300, Ezequiel Garcia wrote:
> Convert devm_request_and_ioremap() to the newly introduced
> devm_ioremap_resource() which provides more consistent error handling.
>
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia at free-electrons.com>
> ---
> drivers/thermal/mvebu_thermal.c | 6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/thermal/mvebu_thermal.c b/drivers/thermal/mvebu_thermal.c
> index ef04e4e..089b43d 100644
> --- a/drivers/thermal/mvebu_thermal.c
> +++ b/drivers/thermal/mvebu_thermal.c
> @@ -86,11 +86,9 @@ static int mvebu_thermal_probe(struct platform_device *pdev)
> if (!priv)
> return -ENOMEM;
>
> - priv->sensor = devm_request_and_ioremap(&pdev->dev, res);
> - if (!priv->sensor) {
> - dev_err(&pdev->dev, "Failed to request_ioremap memory\n");
> + priv->sensor = devm_ioremap_resource(&pdev->dev, res);
> + if (!priv->sensor)
> return -EADDRNOTAVAIL;
> - }
Hi Ezequiel
It would be better to return priv->sensor, not a fixed error code.
Andrew
More information about the linux-arm-kernel
mailing list