[PATCH V4 6/9] ARM: mxs: Provide regulator to pwm-backlight

Marek Vasut marex at denx.de
Tue Mar 19 17:35:05 EDT 2013


Dear Andrew Chew,

> > Dear Andrew Chew,
> > 
> > > The pwm-backlight driver now takes a mandatory regulator that is
> > > gotten during driver probe.  Initialize a dummy regulator to satisfy
> > > this requirement.
> > > 
> > > Signed-off-by: Andrew Chew <achew at nvidia.com>
> > 
> > Do we really need a mandatory regulator? Why can't it be optional?
> > 
> > Best regards,
> > Marek Vasut
> 
> Because for those using board setup code (and not devicetree), it was
> not possible to distinguish between opting out of the regulator, and
> deferred probe, without adding something to the platform data that
> board setup code needed to fill in anyway.

Sure, but this adds a bit of overhead for the DT platforms, no?

Other than this curiosity, I have no problems with this stuff.

Best regards,
Marek Vasut



More information about the linux-arm-kernel mailing list