[PATCH v2 1/2] ARM: vexpress: Enable regulator framework when MMCI is in use

[Russell King - ARM Linux]

On Mon, Mar 18, 2013 at 06:16:57PM +0000, Pawel Moll wrote:
> On Mon, 2013-03-18 at 18:03 +0000, Russell King - ARM Linux wrote:
> > > Without the regulator framework present there are no valid operating
> > > voltages reported and the device initialisation fails:
> > > 
> > > mmci-pl18x 1c050000.mmci: mmc0: PL180 manf 41 rev0 at 0x1c050000 irq 41,42 (pio)
> > > mmc0: host doesn't support card's voltages
> > > mmc0: error -22 whilst initialising MMC card
> > 
> > Okay, this isn't going to work, because this means it's broken on a whole
> > load of platforms.  What it means is that this commit:
> > 
> > commit 599c1d5c750ddf528c7c6d3cdc466708f0502e66
> > Author: Ulf Hansson <ulf.hansson at linaro.org>
> > Date:   Mon Jan 7 16:22:50 2013 +0100
> > 
> >     ARM: 7620/1: mmc: mmci: Convert to use mmc_regulator_get_supply
> >     
> >     By using the mmc_regulator_get_supply API we are able to do some
> >     cleanups of the regulator code. Additionally let the regulator
> >     API handle the error printing.
> >     
> >     Cc: Chris Ball <cjb at laptop.org>
> >     Signed-off-by: Ulf Hansson <ulf.hansson at linaro.org>
> >     Signed-off-by: Russell King <rmk+kernel at arm.linux.org.uk>
> > 
> > is actually wrong and probably needs reverting.
> 
> Reverting it will not change anything as the driver had the same
> dependency before, just using :

Umm.  If CONFIG_REGULATOR is not set with the patch reverted, the
regulator support is not used at all, and the ocrmask comes from
the platform data.