[PATCH 05/29] arm64: KVM: Basic ESR_EL2 helpers and vcpu register access

[Geoff Levand]

Hi Marc,

On Tue, 2013-03-05 at 03:47 +0000, Marc Zyngier wrote:
> --- /dev/null
> +++ b/arch/arm64/include/asm/kvm_emulate.h
...

> +static inline bool vcpu_mode_is_32bit(struct kvm_vcpu *vcpu)
> +{
> +	return false;	/* 32bit? Bahhh... */
> +}
> +
> +static inline bool kvm_condition_valid(struct kvm_vcpu *vcpu)
> +{
> +	return true;	/* No conditionals on arm64 */
> +}


Does it make sense to have these routines take a const object?

  static inline bool vcpu_mode_is_32bit(struct kvm_vcpu const *vcpu)

-Geoff