[PATCH] genirq: allow an alternative setup for the mask cache

Thomas Gleixner tglx at linutronix.de
Fri Mar 15 07:02:41 EDT 2013


On Fri, 15 Mar 2013, Holger Brunck wrote:
> On 03/14/2013 06:45 PM, Simon Guinot wrote:
> >> @@ -243,9 +243,12 @@ void irq_setup_generic_chip(struct irq_chip_generic *gc, u32 msk,
> >>  	list_add_tail(&gc->list, &gc_list);
> >>  	raw_spin_unlock(&gc_lock);
> >>  
> >> +	/* Setup pointer to mask_cache */
> >> +	gc->pmask_cache = &gc->mask_cache;
> > 
> > You need a flag here to choose between gc->mask_cache and
> > ct->mask_cache.
> > 
> 
> hm, even here? Isn't it enough to do this if irq_setup_alt_chip is called?

Yes, you need to do it at both places. We install ct[0] by default, so
if nothing calls setup_alt_chip() you lost.
 
Thanks,

	tglx



More information about the linux-arm-kernel mailing list