[PATCH v4 2/5] clk: hi3xxx: add clock support

Haojian Zhuang haojian.zhuang at linaro.org
Thu Mar 14 05:49:22 EDT 2013


On 14 March 2013 17:09, Arnd Bergmann <arnd at arndb.de> wrote:
> On Thursday 14 March 2013, Haojian Zhuang wrote:
>>
>> Add clock support with device tree on Hisilicon SoC.
>>
>> Signed-off-by: Haojian Zhuang <haojian.zhuang at linaro.org>
>
> Looks good to me, just one final comment from my side:
>
>> +
>> +static struct hs_clk hs_clk;
>> +
>> +static void __init hs_init_clocks(void);
>> +
>
> Please move the hs_init_clocks() function itself to the top of the file to
> avoid the forward declaration.
>
>         Arnd

No problem.

Regards
Haojian



More information about the linux-arm-kernel mailing list