[PATCH 2/7] ARM: shmobile: marzen: add USB EHCI driver support
Kuninori Morimoto
kuninori.morimoto.gx at renesas.com
Wed Mar 13 21:09:55 EDT 2013
Hi Sergei
> > Morimoto-san, I don't understand why this SoC specific platform device
> > ended up in the board file? Could you explain your reasons please?
> > I think this is generally a bad practice as this approach scales badly.
>
> Do you mean it should exist in setup-r8a7779.c ?
>
> I forgot detail of it, but these usb is using callback function,
> and it is using *phy*.
> This phy came from marzen_init_late() with usb_get_phy(USB_PHY_TYPE_USB2);
> This usb_get_phy() is not needed if board doesn't have USB.
>
> You can modify it if you want
And, as you pointed in USB ML,
This rcar_usb_phy driver will need board specific initialization.
(it is not implemented at this point...)
Best regards
---
Kuninori Morimoto
More information about the linux-arm-kernel
mailing list