[PATCH] ARM: mvebu: fix RAM size for Armada XP board DB-MV784MP-GP

Jason Cooper jason at lakedaemon.net
Wed Mar 13 10:50:26 EDT 2013


On Wed, Mar 13, 2013 at 03:37:00PM +0100, Gregory CLEMENT wrote:
> On 03/13/2013 03:30 PM, Sergei Shtylyov wrote:
> > Hello.
> > 
> > On 12-03-2013 19:12, Jason Cooper wrote:
> > 
> >> The board is supplied with a 4GB RAM module.  This value can be
> >> overridden by the bootloader based on probed memory size.  We set it to
> >> a reasonable value here.
> > 
> >> Signed-off-by: Jason Cooper <jason at lakedaemon.net>
> >> ---
> >> As promised, catching this fix in the -rc cycle.
> > 
> >> For those not familiar, earlier versions of the patch adding this board listed
> >> 3GB because that is all that was visible.  I mistaken applied v3 of the patch
> >> instead of v4 which properly listed 4GB.  This patch cleans up my error.
> > 
> >>   arch/arm/boot/dts/armada-xp-gp.dts | 9 ++++-----
> >>   1 file changed, 4 insertions(+), 5 deletions(-)
> > 
> >> diff --git a/arch/arm/boot/dts/armada-xp-gp.dts b/arch/arm/boot/dts/armada-xp-gp.dts
> >> index 1c8afe2..4a2776a 100644
> >> --- a/arch/arm/boot/dts/armada-xp-gp.dts
> >> +++ b/arch/arm/boot/dts/armada-xp-gp.dts
> >> @@ -28,12 +28,11 @@
> >>   		device_type = "memory";
> >>
> >>   		/*
> >> -		 * 4 GB of plug-in RAM modules by default but only 3GB
> >> -		 * are visible, the amount of memory available can be
> >> -		 * changed by the bootloader according the size of the
> >> -		 * module actually plugged
> >> +		 * 4 GB of plug-in RAM modules by default. The amount of memory
> >> +		 * available can be changed by the bootloader according the
> > 
> >     "According to the size".
> > 
> >> +		 * size of the module actually plugged
> >>   		 */
> >> -		reg = <0x00000000 0xC0000000>;
> >> +		reg = <0x00000000 0xD0000000>;
> > 
> >     But this is not 4G?
> 
> You're totally right!
> It should be reg = <0x00000000 0xF0000000>;

$ printf "0x%08x\n" `echo "4 * (1024 ^ 3)" | bc`
0x100000000

?

thx,

Jason.



More information about the linux-arm-kernel mailing list