[PATCH v2 05/14] ARM: integrator: use clocksource_of_init for sp804

Linus Walleij linus.walleij at linaro.org
Wed Mar 13 01:25:13 EDT 2013


On Tue, Mar 12, 2013 at 7:54 PM, Arnd Bergmann <arnd at arndb.de> wrote:
> On Tuesday 12 March 2013, Haojian Zhuang wrote:

>>         timer1: timer at 13000100 {
>>                 compatible = "arm,sp804", "arm,primecell";
>> +               arm,sp804-clockevent = <0>;
>> +               status = "ok";
>>         };
>
> I would prefer to keep the old way of doing this. The "aliases" node is
> meant for configuration, while the timer device itself should not care
> whether it is used as a clockevent or clocksource or some other device.
>
> We could probably change the identifiers in the aliases to
> "linux,clocksource" and "linux,clockevents" instead of
> "arm,timer-primary" and "arm,timer-secondary".

I named it like that exactly to be OS-neutral.

The idea is that what timer is to be used for primary and secondary
may have implications on things like power consumption and
one timer may be broken in the HW etc. That is not a Linux-specific
thing.

A bit hard to do things right here :-/

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list