[RFC PATCH 2/3] usb: udc: delete the vbus indicator at individual driver

Felipe Balbi balbi at ti.com
Tue Mar 12 05:46:49 EDT 2013


On Tue, Mar 12, 2013 at 05:03:18PM +0800, Peter Chen wrote:
> Let the common struct usb_gadget own it.
> 
> CC: Alexander Shishkin <alexander.shishkin at linux.intel.com>
> CC: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> CC: Li Yang <leoli at freescale.com>
> CC: Roland Stigge <stigge at antcom.de>
> CC: Yu Xu <yuxu at marvell.com>
> CC: Chao Xie <chao.xie at marvell.com>
> CC: Eric Miao <eric.y.miao at gmail.com>
> CC: Ben Dooks <ben-linux at fluff.org>
> Signed-off-by: Peter Chen <peter.chen at freescale.com>

you need to split this patch, should be something like below:

for_each_driver() {
	initialize gadget->vbus_active (don't remove private method)
}

add vbus_active support to udc-core

for_each_driver() {
	remove driver's private vbus_active method
}

you need one patch per driver so it's easy to review and ack.

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130312/8cb76081/attachment.sig>


More information about the linux-arm-kernel mailing list