[PATCH 1/6] platform-drivers: msm: add single-wire serial bus interface (SSBI) driver
David Brown
davidb at codeaurora.org
Tue Mar 12 02:51:08 EDT 2013
Greg Kroah-Hartman <gregkh at linuxfoundation.org> writes:
>> +static int ssbi_wait_mask(struct msm_ssbi *ssbi, u32 set_mask, u32 clr_mask)
>> +{
>> + u32 timeout = SSBI_TIMEOUT_US;
>> + u32 val;
>> +
>> + while (timeout--) {
>> + val = ssbi_readl(ssbi, SSBI2_STATUS);
>> + if (((val & set_mask) == set_mask) && ((val & clr_mask) == 0))
>> + return 0;
>> + udelay(1);
>
> Busy loop? Really?
Finally was able to dig up some of the reason for this. The
transactions typically take about 5us. In the case of contention with
another CPU, it could take as much as 20us.
Would it be sufficient to just explain this in a comment?
David
More information about the linux-arm-kernel
mailing list