[PATCH 04/10] bus: introduce an Marvell EBU MBus driver
thomas.petazzoni at free-electrons.com
Fri Mar 8 03:10:52 EST 2013
Dear Jason Gunthorpe,
On Thu, 7 Mar 2013 16:05:16 -0700, Jason Gunthorpe wrote:
> So what is the point of that? Get rid of your driver, have the mbus
> driver set up its own windows and put cfi-flash directly under
> mbus. Smaller, simpler, clearer, better.
No, we will still need the Device Bus driver to set up the timings.
> What you've done is *exactly* the sort of thing I was warning against
> BTW, I've made the same basic choice on our Kirkwood systems. The NAND
> timing pameters are set by the bootloader and the kernel doesn't touch
> them. The bootloader knows which flash chip is placed on the board so
> only it knows the correct timing parameters. There is not any reason
> to communicate them to the kernel.
That's _your_ choice, and it's entirely inconsistent with most kernel
practices. For example, we have the pinctrl subsystem, which precisely
aims at empowering the kernel in terms of pin muxing, while previously,
it was a mix of custom kernel APIs, or reliance on the bootloader for
having setting up the pin muxing.
Sorry, but we _do_ want the kernel to be able to set those timings
parameters, and therefore, a Device Bus driver will be needed,
regardless of whether it creates the address window or not.
> > In conclusion: there is absolutely no need to change the NOR driver,
> > and there is no need to explictly add an explicit description of the
> > NOR window in the device tree.
> As I've said, a DT that has child nodes without an associated address
> map is broken.
That's a statement without any arguments. How can we have a serious
technical discussion if what you bring is just "this is broken", with no
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
More information about the linux-arm-kernel