[PATCH] pinctrl: single: avoid to set read only object

Haojian Zhuang haojian.zhuang at linaro.org
Thu Mar 7 10:37:58 EST 2013


On 7 March 2013 15:48, Linus Walleij <linus.walleij at linaro.org> wrote:
> On Sun, Mar 3, 2013 at 4:01 PM, Haojian Zhuang
> <haojian.zhuang at linaro.org> wrote:
>
>> drivers/pinctrl/pinctrl-single.c:1441:3: error: assignment of member
>> ‘is_generic’ in read-only object
>> make[2]: *** [drivers/pinctrl/pinctrl-single.o] Error 1
>>
>> Since pcs_pinconf_ops is changed to read only structure, probe()
>> function can't set is_generic variable any more. So append new
>> pcs_pinconf_generic_ops.
>>
>> Signed-off-by: Haojian Zhuang <haojian.zhuang at linaro.org>
>
> Isn't this fixed by Axel's much simpler patch?
>
> Yours,
> Linus Walleij

Yes, I prefer to use Axel's fix.

Regards
Haojian



More information about the linux-arm-kernel mailing list