[PATCH 2/2] pinctrl: imx: use pin_func_ids to search the pinctrl item.

Linus Walleij linus.walleij at linaro.org
Wed Mar 6 22:25:28 EST 2013


On Mon, Mar 4, 2013 at 3:18 AM, Dong Aisheng <dong.aisheng at linaro.org> wrote:
> On 1 March 2013 21:07, Linus Walleij <linus.walleij at linaro.org> wrote:
>> On Wed, Feb 27, 2013 at 3:35 AM, Huang Shijie <b32955 at freescale.com> wrote:
>>
>>> The uart may works in DTE mode or DCE mode. The customer can sets the different
>>> modes by the pinctrl. But the pinctrl items for DTE or DCE may share the
>>> same Pad id, such as:
>>>   MX6Q_PAD_EIM_D27__UART2_RXD_DTE and MX6Q_PAD_EIM_D27__WEIM_WEIM_D_27
>>>   share the same MX6Q_PAD_EIM_D27 pad id.
>>>
>>> The current code only search the pinctrl items by pad id. So if there two
>>> pinctrl items shares the same pad id, the current code only use the first one,
>>> even you tell the system to use the second one in the DTS file.
>>>
>>> This patch adds a new field pin_func_ids to imx_pin_group{}, and uses the
>>> pin_func_ids as the index to search the pinctrl items. In this way, we can
>>> avoid the issue.
>>>
>>> Signed-off-by: Huang Shijie <b32955 at freescale.com>
>>
>> Dong/Shawn: what about this patch?
>
> We do not need this patch anymore since we've changed the binding a bit.

OK ignoring this then.

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list