[PATCH v9 8/9] usb: chipidea: tell platform layer the ci core probe's result

Felipe Balbi balbi at ti.com
Fri Mar 1 01:29:18 EST 2013


On Fri, Mar 01, 2013 at 09:45:51AM +0800, Peter Chen wrote:
> On Thu, Feb 28, 2013 at 12:45:59PM +0200, Felipe Balbi wrote:
> > Hi,
> > 
> > On Thu, Feb 28, 2013 at 06:06:55PM +0800, Peter Chen wrote:
> > 
> > > For runtime pm disabled, we may had to add some ugly things, like
> > > notify core probe fail, and platform layer needs to handle this failed
> > > notify.
> > 
> > Please stop talking about about "notify core probe fail" that will never
> > happen. Not today, not ever. Forget that idea.
> 
> Of course, it is ugly way, I just thought if it will affect power, eg dvfs,
> bus freq if the usb clock is on. Maybe the user will find USB core init fails
> case causes runtime power rise, and fix the core init fail bug.

right, we need to fix the bug, but hiding it under some obscure way of
passing return values back to glue layer isn't correct. We should fix
the real issue, always, instead of hacking around buggy code.

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130301/5a467e76/attachment.sig>


More information about the linux-arm-kernel mailing list