[PATCH v3 5/5] drivers: bus: imx-weim: Add support for i.MX1/21/25/27/31/35/50/51/53
shawn.guo at linaro.org
Mon Jun 24 08:38:19 EDT 2013
On Mon, Jun 24, 2013 at 03:49:53PM +0400, Alexander Shiyan wrote:
> > > @@ -81,6 +118,9 @@ static int __init weim_probe(struct platform_device *pdev)
> > > void __iomem *base;
> > > int ret;
> > >
> > > + if (!pdev->dev.of_node)
> > > + return -ENOTSUPP;
> > > +
> > Is it really necessary? Since we only support DT probe, we can not
> > reach here if the of_node is NULL.
> In fact, nothing prevents to add to the board file line like
> platform_device_register_simple ("imx-weim", 0, res, res_cnt);
Reasonability prevents that:
1) We no longer accept any changes like that.
2) The device driver does not work with platform probe anyway. What's
the point of doing that?
> In this case, the core will crush. I make it impossible to use.
> Consider it unnecessary checks?
Yes, unnecessary check for me.
More information about the linux-arm-kernel