Re: [PATCH v3 5/5] drivers: bus: imx-weim: Add support for i.MX1/21/25/27/31/35/50/51/53
shc_work at mail.ru
Mon Jun 24 07:49:53 EDT 2013
> On Sun, Jun 23, 2013 at 11:48:18AM +0400, Alexander Shiyan wrote:
> > Signed-off-by: Alexander Shiyan <shc_work at mail.ru>
> Can you write up something for the commit log? Leaving it empty for
> such a patch with tens of LOC is not a nice thing.
> > @@ -81,6 +118,9 @@ static int __init weim_probe(struct platform_device *pdev)
> > void __iomem *base;
> > int ret;
> > + if (!pdev->dev.of_node)
> > + return -ENOTSUPP;
> > +
> Is it really necessary? Since we only support DT probe, we can not
> reach here if the of_node is NULL.
In fact, nothing prevents to add to the board file line like
platform_device_register_simple ("imx-weim", 0, res, res_cnt);
In this case, the core will crush. I make it impossible to use.
Consider it unnecessary checks?
More information about the linux-arm-kernel