Defining schemas for Device Tree
tomasz.figa at gmail.com
Wed Jul 31 19:04:05 EDT 2013
On Wednesday 31 of July 2013 14:47:12 Stephen Warren wrote:
> On 07/30/2013 05:23 PM, jonsmirl at gmail.com wrote:
> > On Tue, Jul 30, 2013 at 7:03 PM, Mark Brown <broonie at kernel.org>
> >> On Tue, Jul 30, 2013 at 06:19:08PM -0400, jonsmirl at gmail.com wrote:
> >>> FDT is versioned and PowerPC docs say that multiple versions have
> >>> been
> >>> released. If we find enough flaws we could do a new release then
> >>> use
> >>> the quirks scheme to read the older versions.
> >> That does involve updating everything that wants to understand FDTs
> >> in
> >> the new FDT format version though. I'm not sure that's going to be
> >> greeted with universal enthusiasm.
> > Shipped hardware containing FDTs would keep the version they shipped
> > with. That's the point of making this a stable ABI. The Linux quirk
> > code would convert the older format to the new format at boot time.
> > So to change this you need to:
> > 1) change dtc to produce the new version
> > 2) adjust the kernel code to understand the new version
> > 3) adjust the quirk code to convert the known set of older firmware
> > based FDTs into the new format. For the simple string case the strings
> > would be turned into indirect pointers instead of being in-line.
> There's one issue issue with the quirk/conversion layer in the kernel.
> Various combinations are supposed to work:
> 1) The "current" kernel with the "current" DTB. I think everyone agrees
> on that much:-)
> 2) Using an old DTB with a new kernel. This could be handled by having
> stable DT bindings, and/or by having a quirk/conversion layer in the
> kernel to convert old DTBs into whatever format the new kernel expects.
> 3) Using a new DTB with a old kernel. Rob Herring raised the point that
> a firmware update (which might include updating the DTB the firmware
> passes to the kernel) should not make the kernel you have installed in
> the filesystem fail to boot.
> I'm assuming that if the quirk/conversion layer you're championing were
> the solution chosen for (2), then at least some of the time, people
> would start using the new DT binding when writing new DTs, or modifying
> existing DTs. That would break point (3) above, since the new DT would
> no longer work with the old kernel.
> I think the only way to satisfy all three points above is to have truly
> stable backwards-compatible bindings, without relying on any in-kernel
> conversion layer.
IMHO stable bindings is the way to go. We already managed to keep lot of
existing bindings stable, see most of the generic bindings. Those got much
more thought at design stage, much more review and ended up being
something that could be stabilized.
If we define the process of bindings introduction correctly, we should be
able to filter out those that won't work as stable thing and stabilize
those that will. This is why we may need a staging tree for bindings and a
way to develop such bindings to make them stable at some point of time.
I'm not really sure how Greg's staging tree works, but we might be able to
get some hints for creating our staging process from him (now on Cc).
More information about the linux-arm-kernel