[PATCH v2 2/3] serial: mxs: enable the DMA only when the RTS/CTS is valid

Greg KH gregkh at linuxfoundation.org
Fri Jul 26 19:10:08 EDT 2013


On Wed, Jul 17, 2013 at 03:33:22PM +0800, Huang Shijie wrote:
> 于 2013年07月16日 17:54, Uwe Kleine-König 写道:
> >On Tue, Jul 16, 2013 at 02:55:31PM +0800, Huang Shijie wrote:
> >>The original DMA support works only when RTS/CTS is enabled.
> >What is original here?
> >
> i will add more information for this in the next version.
> >>But after several patches, DMA support has lost this limit.
> >This is still misleading.
> >
> >>This patch adds an optional property for the UART DT node
> >>which indicates the UART has RTS and CTS lines.
> >>
> >>This patch also adds a macro MXS_AUART_RTSCTS, and uses it to check
> >>RTS/CTS before we enable the DMA for the UART.
> >I still think this should go to stable. The options are:
> >
> >	a) also take patch 1 into stable
> >	b) apply this patch without patch 1
> >
> >I don't know if option a) is OK, b) is probably preferable. And as Greg
> to Greg:
> 
> I think a) is ok to me. what's your opinion?

Please reorder them, making patch 2 first, and mark it for stable, then
do patch 1, and the rest, so I don't have to take non-needed patches
into the stable tree.

thanks,

greg k-h



More information about the linux-arm-kernel mailing list