[v3 3/3] sata: imx: add ahci sata support on imx platforms
Tejun Heo
tj at kernel.org
Fri Jul 5 13:43:05 EDT 2013
Hello,
On Fri, Jul 05, 2013 at 05:52:22PM +0800, Richard Zhu wrote:
> - CAP_SSS(bit20) of the HOST_CAP is writable, default
> value is '0', should be configured to be '1'
> - bit0 (only one AHCI SATA port on imx6q) of the
> HOST_PORTS_IMPL should be set to be '1'.(default 0)
> - One Vendor Specific register HOST_TIMER1MS(offset:0xe0)
> should be configured regarding to the frequency of AHB
> bus clock.
> - Configurations of the AHCI PHY clock, and the signal
> parameters of the GPR13
Can't you just add a platform specific init callback to ahci_platform?
I don't see how these small differences in init sequence justify a
separate driver.
Thanks.
--
tejun
More information about the linux-arm-kernel
mailing list