[PATCH v3 1/1 net-next] net: fec: add napi support to improve proformance

Frank Li lznuaa at gmail.com
Tue Jan 29 00:03:38 EST 2013


2013/1/26 Francois Romieu <romieu at fr.zoreil.com>:
> Waskiewicz Jr, Peter P <peter.p.waskiewicz.jr at intel.com> :
> [...]
>> Also, when you're disabling interrupts above, you're doing that in your
>> HW interrupt handler, you should be using spin_lock_irqsave()/irq_restore().
>
> Does the platform forbid to defer FEC_EIR / FEC_IEVENT write to the napi

I can clean FEC_IEVENT, but rx irq still issue if new package
received. I tested, performance drop if just clean FEC_IEVENT

> poll handler and only disable the irq through FEC_EIMR / FEC_IMASK in
> fec_enet_interrupt so as to remove the spinlock ?

I can remove this spin lock in other way.  I will send new patch.

>
> (Frank, please keep an empty line between variables declarations and
> function body).

Okay.

>
> --
> Ueimor



More information about the linux-arm-kernel mailing list