[PATCH v3 1/1 net-next] net: fec: add napi support to improve proformance

Francois Romieu romieu at fr.zoreil.com
Fri Jan 25 17:23:06 EST 2013


Waskiewicz Jr, Peter P <peter.p.waskiewicz.jr at intel.com> :
[...]
> Also, when you're disabling interrupts above, you're doing that in your
> HW interrupt handler, you should be using spin_lock_irqsave()/irq_restore().

Does the platform forbid to defer FEC_EIR / FEC_IEVENT write to the napi
poll handler and only disable the irq through FEC_EIMR / FEC_IMASK in
fec_enet_interrupt so as to remove the spinlock ?

(Frank, please keep an empty line between variables declarations and
function body).

-- 
Ueimor



More information about the linux-arm-kernel mailing list