[PATCH v2] arch/arm/mach-s5pv210: adding ifdef CONFIG_CPU_S5PV210to fix compiling issue
Kukjin Kim
kgene.kim at samsung.com
Thu Jan 17 22:33:34 EST 2013
Chen,Gang( ??) wrote:
>
>
> > For subject:
> > Please see the git log before your commit, it should be helpful to you.
> > In this case, 'ARM: S5PV210: ...' is used.
>
> thank you, I should notice it next time.
> an incorrect subject is not easy to get maintainer's notice
> maybe it is the reason why you can not reply in time, since you can not notice it.
>
> :-)
>
Just I was busy ;-) sorry for late my reply.
Anyway Gang, don't post with html typed e-mail, probably, you got some kind of error that your previous reply wasn't accepted from mailing list mail server. Please make sure that your e-mail is plain text type for mailing list.
[...]
> > I don't think so, because common.c in mach-s5pv210 should be built with
> > selecting CONFIG_CPU_S5PV210, actually it depends on CONFIG_ARCH_S5PV210
> > though.
> >
> > Any concerns, please let me know.
>
> ok, thank you.
> and
> is it suitable to delete the reletive code of " define NULL in common.h for s5pv210_* " ?
> it seems they are wast.
>
Yes, right. We don't need more that. I missed it when I introduced common.[ch] local at the commit 3fa754c2. Thanks for pointing out and I will sort out.
[...]
Thanks.
- Kukjin
More information about the linux-arm-kernel
mailing list