[PATCH] [RFC] ARM: compile fix for DEBUG_LL=y && MMU=n

Stephen Warren swarren at wwwdotorg.org
Wed Jan 16 12:43:32 EST 2013

On 01/16/2013 07:32 AM, Uwe Kleine-König wrote:
> debug_ll_addr is only used on machines with an MMU so it can be #ifdef'ed
> out safely. This fixes:
> arch/arm/kernel/debug.S: Assembler messages:
> arch/arm/kernel/debug.S:104: Error: too many positional arguments
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> Cc: Rob Herring <rob.herring at calxeda.com>
> Cc: Stephen Warren <swarren at nvidia.com>
> Cc: Olof Johansson <olof at lixom.net>
> ---
> The obvious alternative fix is to make addruart on !MMU take 3
> arguments, too.
> The problem was introduced in
> 	e5c5f2a (ARM: implement debug_ll_io_init())

It may be useful to mention that in the commit message.

Sorry for the breakage. Are there any ARM defconfigs for !MMU?

Reviewed-by: Stephen Warren <swarren at nvidia.com>

(although should the second copy of debug_ll_addr at the end of the file
be ifdef'd away too; the one for CONFIG_DEBUG_SEMIHOSTING)?

More information about the linux-arm-kernel mailing list