[PATCH] [RFC] ARM: compile fix for DEBUG_LL=y && MMU=n

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Wed Jan 16 09:32:06 EST 2013


debug_ll_addr is only used on machines with an MMU so it can be #ifdef'ed
out safely. This fixes:

arch/arm/kernel/debug.S: Assembler messages:
arch/arm/kernel/debug.S:104: Error: too many positional arguments

Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
Cc: Rob Herring <rob.herring at calxeda.com>
Cc: Stephen Warren <swarren at nvidia.com>
Cc: Olof Johansson <olof at lixom.net>
---
The obvious alternative fix is to make addruart on !MMU take 3
arguments, too.

The problem was introduced in

	e5c5f2a (ARM: implement debug_ll_io_init())

which appeared in v3.8-rc1.
---
 arch/arm/kernel/debug.S |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/kernel/debug.S b/arch/arm/kernel/debug.S
index 6809200..14f7c3b 100644
--- a/arch/arm/kernel/debug.S
+++ b/arch/arm/kernel/debug.S
@@ -100,12 +100,14 @@ ENTRY(printch)
 		b	1b
 ENDPROC(printch)
 
+#ifdef CONFIG_MMU
 ENTRY(debug_ll_addr)
 		addruart r2, r3, ip
 		str	r2, [r0]
 		str	r3, [r1]
 		mov	pc, lr
 ENDPROC(debug_ll_addr)
+#endif
 
 #else
 
-- 
1.7.10.4




More information about the linux-arm-kernel mailing list