[PATCH] mmc: mvsdio: Replace IS_ERR_NULL() is with IS_ERR()

Russell King - ARM Linux linux at arm.linux.org.uk
Fri Jan 11 06:11:28 EST 2013


On Fri, Jan 11, 2013 at 12:09:09PM +0100, Thomas Petazzoni wrote:
> Dear Russell King - ARM Linux,
> 
> On Fri, 11 Jan 2013 11:02:10 +0000, Russell King - ARM Linux wrote:
> 
> > What remains?  The assumption that GPIO0 means "no GPIO" rather than
> > testing with gpio_valid() and the IRQ stuff.
> 
> Patches that I have written have been merged by Jason Cooper and while
> adding the DT binding for this driver, it also converts it to use the
> MMC GPIO helpers from drivers/mmc/core/slot-gpio.c, which makes this
> whole GPIO initialization/cleanup a lot simpler.

Please also fix the whole raft of other crap in this driver too, as
I've highlighted previously and in these patches.



More information about the linux-arm-kernel mailing list