[PATCH] mmc: mvsdio: Replace IS_ERR_NULL() is with IS_ERR()

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Fri Jan 11 06:09:09 EST 2013


Dear Russell King - ARM Linux,

On Fri, 11 Jan 2013 11:02:10 +0000, Russell King - ARM Linux wrote:

> What remains?  The assumption that GPIO0 means "no GPIO" rather than
> testing with gpio_valid() and the IRQ stuff.

Patches that I have written have been merged by Jason Cooper and while
adding the DT binding for this driver, it also converts it to use the
MMC GPIO helpers from drivers/mmc/core/slot-gpio.c, which makes this
whole GPIO initialization/cleanup a lot simpler.

See:

  http://git.infradead.org/users/jcooper/linux.git/commitdiff/c3833fbb117bb1a547d29b27a0de4418fa2d5a5a
  http://git.infradead.org/users/jcooper/linux.git/commitdiff/e60a21ed4edb7f33010ab21cefcb20666a9bc7d7

Also, note that Andrew Lunn has sent a v2 of his patch:

Subject: [PATCH v2] mmc: mvsdio: Replace IS_ERR_OR_NULL() with IS_ERR()
Date: Fri, 11 Jan 2013 08:27:52 +0100

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com



More information about the linux-arm-kernel mailing list