[PATCH v3 06/18] ARM: clps711x: cdb89712: Special driver for handling memory is removed

Alexander Shiyan shc_work at mail.ru
Thu Jan 10 10:39:16 EST 2013


On Thu, 10 Jan 2013 15:09:21 +0100
Uwe Kleine-König <u.kleine-koenig at pengutronix.de> wrote:

...
> >  static void __init cdb89712_init(void)
> >  {
> > +	platform_device_register(&cdb89712_flash_pdev);
> > +	platform_device_register(&cdb89712_bootrom_pdev);
> > +	platform_device_register(&cdb89712_sram_pdev);
> This is broken, all these structs are located in .init.data which is
> discarded after the machine is fully booted. Also platformdata must not
> live in init data. Consider using platform_device_register_full which
> allows more data to be init data.

I agree. Error is invisible when not using loadable modules, but will
become apparent when using these.
I will make the necessary changes. Thank you.

-- 
Alexander Shiyan <shc_work at mail.ru>



More information about the linux-arm-kernel mailing list